Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

[nginx-ingress-controller] Add ssl certificate checksum to template #1054

Merged
merged 1 commit into from
May 26, 2016

Conversation

aledbf
Copy link
Contributor

@aledbf aledbf commented May 24, 2016

fixes #800

@aledbf aledbf changed the title WIP: [nginx-ingress-controller] Add ssl certificate checksum to template [nginx-ingress-controller] Add ssl certificate checksum to template May 24, 2016
@simonswine
Copy link
Contributor

cherry-picked with #1063 and works perfectly in my cluster

LGTM

@@ -155,6 +155,7 @@ http {
server {
listen 80{{ if $cfg.useProxyProtocol }} proxy_protocol{{ end }};
{{ if $server.SSL }}listen 443{{ if $cfg.useProxyProtocol }} proxy_protocol{{ end }} ssl http2;
# PEM sha: {{ $server.SSLPemChecksum }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why comment this out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is just a comment. If the secret changes this comment will trigger the reload (diff with the current running cfg)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, hmm. suggest adding a commet about the significance of that comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@aledbf aledbf force-pushed the cert-checksum branch 2 times, most recently from 2eb8dd1 to 4d8cf3d Compare May 26, 2016 03:05
@bprashanth
Copy link

Thanks, LGTM

@bprashanth bprashanth merged commit bdc78d2 into kubernetes-retired:master May 26, 2016
@aledbf aledbf deleted the cert-checksum branch May 26, 2016 15:47
aledbf pushed a commit to aledbf/contrib that referenced this pull request Nov 10, 2016
[nginx-ingress-controller] Add ssl certificate checksum to template
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nginx Ingress Controller - Config file not updated when a secret is updated
4 participants